Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added github actions CI for guardrail policies #3621

Merged
merged 3 commits into from
Jun 17, 2024
Merged

added github actions CI for guardrail policies #3621

merged 3 commits into from
Jun 17, 2024

Conversation

vinaybommana
Copy link
Contributor

Which issue this PR addresses:

as part of ARO-1457

What this PR does / why we need it:

Integrate gator to our CI pipeline to test guardrail policies

the gator cli uses the test.sh script in ARO-RP/pkg/operator/controllers/guardrails/policies/scripts/

@vinaybommana
Copy link
Contributor Author

@microsoft-github-policy-service agree

bitoku
bitoku reviewed Jun 7, 2024
View reviewed changes
Copy link
Collaborator

@bitoku bitoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! lgtm mostly but I have one question.

.github/workflows/ci-guardrailpolicies.yml Outdated Show resolved Hide resolved
jaitaiwan
jaitaiwan approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@jaitaiwan jaitaiwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaitaiwan
Copy link
Contributor

Once CI passes we'll give this a cheeky merge.

@jaitaiwan
Copy link
Contributor

/azp run ci

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jaitaiwan jaitaiwan merged commit bd3a12f into Azure:master Jun 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaitaiwan jaitaiwan jaitaiwan approved these changes

@bitoku bitoku bitoku approved these changes

@SrinivasAtmakuri SrinivasAtmakuri SrinivasAtmakuri approved these changes

@jewzaam jewzaam Awaiting requested review from jewzaam jewzaam is a code owner

@bennerv bennerv Awaiting requested review from bennerv bennerv is a code owner

@hawkowl hawkowl Awaiting requested review from hawkowl hawkowl is a code owner

@rogbas rogbas Awaiting requested review from rogbas rogbas is a code owner

@petrkotas petrkotas Awaiting requested review from petrkotas petrkotas is a code owner

@jharrington22 jharrington22 Awaiting requested review from jharrington22 jharrington22 is a code owner

@cblecker cblecker Awaiting requested review from cblecker cblecker is a code owner

@cadenmarchese cadenmarchese Awaiting requested review from cadenmarchese cadenmarchese is a code owner

@UlrichSchlueter UlrichSchlueter Awaiting requested review from UlrichSchlueter UlrichSchlueter is a code owner

@SudoBrendan SudoBrendan Awaiting requested review from SudoBrendan SudoBrendan is a code owner

@Shivkumar13 Shivkumar13 Awaiting requested review from Shivkumar13

@yjst2012 yjst2012 Awaiting requested review from yjst2012 yjst2012 is a code owner

@anshulvermapatel anshulvermapatel Awaiting requested review from anshulvermapatel anshulvermapatel is a code owner

@hlipsig hlipsig Awaiting requested review from hlipsig hlipsig is a code owner

@tiguelu tiguelu Awaiting requested review from tiguelu tiguelu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vinaybommana @jaitaiwan @bitoku @SrinivasAtmakuri